[linux-uvc-devel] [PATCH v3] uvcvideo: uvc_scan_fallback() for webcams with broken chain

[Laurent Pinchart]

Hello,

Hi,
This patch also fixes "No valid video chain found" for 0bda:5751
(Realtek) which is the front-facing camera in Dell Venue 11 Pro tablets.
Any chance of merging this upstream?

Yes, I'm on it. Sorry for the delay. I've merged the patch in my tree with a
small functional change (and with comments slightly edited), the result is
available at

git://linuxtv.org/pinchartl/media.git uvc/next

Would you be able to test that ?

Some devices have invalid baSourceID references, causing uvc_scan_chain()
to fail, but if we just take the entities we can find and put them
together in the most sensible chain we can think of, turns out they do
work anyway. Note: This heuristic assumes there is a single chain.
At the time of writing, devices known to have such a broken chain are
- Acer Integrated Camera (5986:055a)
- Realtek rtl157a7 (0bda:57a7)
---
Implements fixes from review on March 17th.

[Laurent Pinchart]

Post by Laurent Pinchart

This patch also fixes "No valid video chain found" for 0bda:5751
(Realtek) which is the front-facing camera in Dell Venue 11 Pro tablets.
Any chance of merging this upstream?

Yes, I'm on it. Sorry for the delay. I've merged the patch in my tree with
a small functional change (and with comments slightly edited).
Would you be able to test that ?

I pulled the latest code from there just now (
9226eabf0314a809a097c17a4793becb9a9fcde7) and with some small
adjustments everything seems to work fine on 4.7.0 in Debian Jessie.
Thanks!

Thank you for the report, and apologies for the time it took to solve the
problem.

[Samir Ibradžić]

Is this getting mainlined, ever?

Post by Laurent Pinchart

Post by Laurent Pinchart

This patch also fixes "No valid video chain found" for 0bda:5751
(Realtek) which is the front-facing camera in Dell Venue 11 Pro tablets.
Any chance of merging this upstream?

Yes, I'm on it. Sorry for the delay. I've merged the patch in my tree with
a small functional change (and with comments slightly edited).
Would you be able to test that ?

I pulled the latest code from there just now (
9226eabf0314a809a097c17a4793becb9a9fcde7) and with some small
adjustments everything seems to work fine on 4.7.0 in Debian Jessie.
Thanks!

Thank you for the report, and apologies for the time it took to solve the
problem.

------------------------------------------------------------------------------

[Henrik Ingo]

Hi Samir

The patch has now gotten 2 sign-offs, and was merged into the
linuxtv.org "media_tree" here:
https://git.linuxtv.org/media_tree.git/commit/?id=e950267ab802c8558f1100eafd4087fd039ad634

I've been hopeful that this is a tree that would be wholesale pulled
upstream once the merge window opens again (early 2017, I think?). But
I don't actually know whether that is a fact and in fact I have zero
experience with this process.

henrik

Post by Samir Ibradžić
Is this getting mainlined, ever?

Post by Laurent Pinchart

Post by Laurent Pinchart

This patch also fixes "No valid video chain found" for 0bda:5751
(Realtek) which is the front-facing camera in Dell Venue 11 Pro tablets.
Any chance of merging this upstream?

Yes, I'm on it. Sorry for the delay. I've merged the patch in my tree with
a small functional change (and with comments slightly edited).
Would you be able to test that ?

I pulled the latest code from there just now (
9226eabf0314a809a097c17a4793becb9a9fcde7) and with some small
adjustments everything seems to work fine on 4.7.0 in Debian Jessie.
Thanks!

Thank you for the report, and apologies for the time it took to solve the
problem.

------------------------------------------------------------------------------
_______________________________________________
Linux-uvc-devel mailing list
https://lists.sourceforge.net/lists/listinfo/linux-uvc-devel

[Henrik Ingo]

Just to follow up, this patch was merged by Linus yesterday.
https://github.com/torvalds/linux/commit/e950267ab802c8558f1100eafd4087fd039ad634

I'd like to thank people on this list for help and advice, as this was
my first ever patch to the kernel. The "Suggested-by" header was lost
in the process, but I'd especially like to thank Arno Wilhelm for
doing the debugging and discovering that the Acer camera actually
works if the error that happens in the loading phase of the driver is
just ignored.


henrik
PS: I will probably unsubscribe in the near future, but feel free to
cc me if there are any questions.

Post by Henrik Ingo
Hi Samir
The patch has now gotten 2 sign-offs, and was merged into the
https://git.linuxtv.org/media_tree.git/commit/?id=e950267ab802c8558f1100eafd4087fd039ad634
I've been hopeful that this is a tree that would be wholesale pulled
upstream once the merge window opens again (early 2017, I think?). But
I don't actually know whether that is a fact and in fact I have zero
experience with this process.
henrik

Post by Samir Ibradžić
Is this getting mainlined, ever?

Post by Laurent Pinchart

Post by Laurent Pinchart

This patch also fixes "No valid video chain found" for 0bda:5751
(Realtek) which is the front-facing camera in Dell Venue 11 Pro tablets.
Any chance of merging this upstream?

Yes, I'm on it. Sorry for the delay. I've merged the patch in my tree with
a small functional change (and with comments slightly edited).
Would you be able to test that ?

I pulled the latest code from there just now (
9226eabf0314a809a097c17a4793becb9a9fcde7) and with some small
adjustments everything seems to work fine on 4.7.0 in Debian Jessie.
Thanks!

Thank you for the report, and apologies for the time it took to solve the
problem.

------------------------------------------------------------------------------
_______________________________________________
Linux-uvc-devel mailing list
https://lists.sourceforge.net/lists/listinfo/linux-uvc-devel

--
[phone] skype: henrik.ingo irc: hingo
www.openlife.cc
My LinkedIn profile: http://fi.linkedin.com/pub/henrik-ingo/3/232/8a7

[Samir Ibradžić]

excellent work, much obliged!

Post by Henrik Ingo
Just to follow up, this patch was merged by Linus yesterday.
https://github.com/torvalds/linux/commit/e950267ab802c8558f1100eafd4087fd039ad634
I'd like to thank people on this list for help and advice, as this was
my first ever patch to the kernel. The "Suggested-by" header was lost
in the process, but I'd especially like to thank Arno Wilhelm for
doing the debugging and discovering that the Acer camera actually
works if the error that happens in the loading phase of the driver is
just ignored.
henrik
PS: I will probably unsubscribe in the near future, but feel free to
cc me if there are any questions.

Post by Henrik Ingo
Hi Samir
The patch has now gotten 2 sign-offs, and was merged into the
https://git.linuxtv.org/media_tree.git/commit/?id=e950267ab802c8558f1100eafd4087fd039ad634
I've been hopeful that this is a tree that would be wholesale pulled
upstream once the merge window opens again (early 2017, I think?). But
I don't actually know whether that is a fact and in fact I have zero
experience with this process.
henrik

Post by Samir Ibradžić
Is this getting mainlined, ever?

Post by Laurent Pinchart

Post by Laurent Pinchart

This patch also fixes "No valid video chain found" for 0bda:5751
(Realtek) which is the front-facing camera in Dell Venue 11 Pro tablets.
Any chance of merging this upstream?

Yes, I'm on it. Sorry for the delay. I've merged the patch in my tree with
a small functional change (and with comments slightly edited).
Would you be able to test that ?

I pulled the latest code from there just now (
9226eabf0314a809a097c17a4793becb9a9fcde7) and with some small
adjustments everything seems to work fine on 4.7.0 in Debian Jessie.
Thanks!

Thank you for the report, and apologies for the time it took to solve the
problem.

------------------------------------------------------------------------------
_______________________________________________
Linux-uvc-devel mailing list
https://lists.sourceforge.net/lists/listinfo/linux-uvc-devel

--
[phone] skype: henrik.ingo irc: hingo
www.openlife.cc
My LinkedIn profile: http://fi.linkedin.com/pub/henrik-ingo/3/232/8a7

[Arno Wilhelm]

Hi Henrik,

Post by Henrik Ingo
Just to follow up, this patch was merged by Linus yesterday.
https://github.com/torvalds/linux/commit/e950267ab802c8558f1100eafd4087fd039ad634

I really want to thank you for your efforts and all the work you have
put into this!
And I am glad that my laptop camera will work without patching future kernels :)

Post by Henrik Ingo
in the process, but I'd especially like to thank Arno Wilhelm for
doing the debugging and discovering that the Acer camera actually
works if the error that happens in the loading phase of the driver is
just ignored.

Maybe I did some debugging, but it was Samir who detected that
ignoring the error made the camera working.
(See this thread here:
https://sourceforge.net/p/linux-uvc/mailman/message/34181466/.)
He sent a patch there and so he deserves our thanks.


Arno

[Henrik Ingo]

Ah, you're right! Thanks for correcting me and letting me credit the
right person: Samir. Both of you were very helpful though.

henrik

Post by Arno Wilhelm
Hi Henrik,

Post by Henrik Ingo
Just to follow up, this patch was merged by Linus yesterday.
https://github.com/torvalds/linux/commit/e950267ab802c8558f1100eafd4087fd039ad634

I really want to thank you for your efforts and all the work you have
put into this!
And I am glad that my laptop camera will work without patching future kernels :)

Post by Henrik Ingo
in the process, but I'd especially like to thank Arno Wilhelm for
doing the debugging and discovering that the Acer camera actually
works if the error that happens in the loading phase of the driver is
just ignored.

Maybe I did some debugging, but it was Samir who detected that
ignoring the error made the camera working.
https://sourceforge.net/p/linux-uvc/mailman/message/34181466/.)
He sent a patch there and so he deserves our thanks.
Arno